feat: provide access to arbitrary interpreters #2507
Draft
+213
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Run a specific interpreter: * `bazel run @rules_python//tools/run --@rules_python//python/config_settings:python_version=3.12` Run interpreter from a binary: * `bazel run @rules_python//tools/run --@rules_python//tools/run:bin=//my:binary`
$ bazel run //python/bin:repl
$ bazel run //python/bin:repl --//python/bin:repl_dep=//python/runfiles
philsc
commented
Dec 16, 2024
| `@rules_python//python/bin:interpreter_src` target. | ||
|
|
||
| ``` | ||
| $ bazel run @rules_python//python/bin:interpreter --@rules_python//python/bin:interpreter_src=//path/to:bin |
There was a problem hiding this comment.
Need to find an "aha!" example for this.
There was a problem hiding this comment.
What about using the publishing twine binary? Something that exists within rules_python could do the trick.
aignas
reviewed
Dec 16, 2024
| ## Accessing the underlying interpreter | ||
|
|
||
| To access the interpreter that bazel manages, you can use the | ||
| `@rules_python//python/bin:interpreter` target. This is a binary target with |
There was a problem hiding this comment.
Nit: why not just python?
Suggested change
| `@rules_python//python/bin:interpreter` target. This is a binary target with | |
| `@rules_python//python/bin:python` target. This is a binary target with |
| @@ -0,0 +1,40 @@ | |||
| load("@bazel_skylib//lib:paths.bzl", "paths") | |||
There was a problem hiding this comment.
Please move the implementation to //python/private/interpreter.bzl and re-export here
| `@rules_python//python/bin:interpreter_src` target. | ||
|
|
||
| ``` | ||
| $ bazel run @rules_python//python/bin:interpreter --@rules_python//python/bin:interpreter_src=//path/to:bin |
There was a problem hiding this comment.
What about using the publishing twine binary? Something that exists within rules_python could do the trick.
| self._run_module_test("3.11") | ||
|
|
||
| def test_run_module_3_12(self): | ||
| self._run_module_test("3.12") |
There was a problem hiding this comment.
It would be great to add a test that imports:
- The code that is in the
//python/bin:interpreter_src - The code that is in the transitive deps of the
//python/bin:interpreter_src. Maybe depending ontwinecould be an option in the tests and then we could attempt importing one of its deps?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are some use cases that folks want to cover here. They are
discussed in this Slack thread. The high-level summary is:
to minimize environmental issues.
so that they can use the correct interpreter.
This patch adds to @rickeylev's work from #2359 by adding docs
and a few integration tests.